From 5db3f8248cd0a489d8dcdd347f1cf6fd73ca2ba2 Mon Sep 17 00:00:00 2001 From: Tobias Kessels Date: Wed, 1 Oct 2025 13:25:59 +0200 Subject: [PATCH] Fix Makefile coverage target and add check-help-coverage.sh to containers - Fixed 'make coverage' command (was using empty variable) - Now runs: docker run --rm tabledevil/file-analysis:latest check-help-coverage.sh - Added check-help-coverage.sh script to both Dockerfiles - Made script executable in both images - Coverage check now works properly without mounting volumes --- Dockerfile | 3 ++- Dockerfile.scratch | 3 ++- Makefile | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Dockerfile b/Dockerfile index 78861b9..94e5aeb 100644 --- a/Dockerfile +++ b/Dockerfile @@ -54,10 +54,11 @@ ADD scripts/fhelp /usr/local/bin/fhelp ADD scripts/import-remnux-cheatsheets.sh /usr/local/bin/import-remnux-cheatsheets.sh ADD scripts/convert-remnux-cheats.py /usr/local/bin/convert-remnux-cheats.py ADD scripts/add-tool-cheats.sh /usr/local/bin/add-tool-cheats.sh +ADD scripts/check-help-coverage.sh /usr/local/bin/check-help-coverage.sh # Create streamlined offline help system (tldr + cheat) RUN chmod +x /usr/local/bin/create-offline-help-system.sh /usr/local/bin/find-tool /usr/local/bin/fhelp /usr/local/bin/import-remnux-cheatsheets.sh \ - && chmod +x /usr/local/bin/convert-remnux-cheats.py /usr/local/bin/add-tool-cheats.sh \ + && chmod +x /usr/local/bin/convert-remnux-cheats.py /usr/local/bin/add-tool-cheats.sh /usr/local/bin/check-help-coverage.sh \ && /usr/local/bin/create-offline-help-system.sh \ && /usr/local/bin/add-tool-cheats.sh diff --git a/Dockerfile.scratch b/Dockerfile.scratch index 3bc8dd9..45e16a1 100644 --- a/Dockerfile.scratch +++ b/Dockerfile.scratch @@ -77,10 +77,11 @@ ADD scripts/fhelp /usr/local/bin/fhelp ADD scripts/import-remnux-cheatsheets.sh /usr/local/bin/import-remnux-cheatsheets.sh ADD scripts/convert-remnux-cheats.py /usr/local/bin/convert-remnux-cheats.py ADD scripts/add-tool-cheats.sh /usr/local/bin/add-tool-cheats.sh +ADD scripts/check-help-coverage.sh /usr/local/bin/check-help-coverage.sh # Create streamlined offline help system (tldr + cheat) RUN chmod +x /usr/local/bin/create-offline-help-system.sh /usr/local/bin/find-tool /usr/local/bin/fhelp /usr/local/bin/import-remnux-cheatsheets.sh \ - && chmod +x /usr/local/bin/convert-remnux-cheats.py /usr/local/bin/add-tool-cheats.sh \ + && chmod +x /usr/local/bin/convert-remnux-cheats.py /usr/local/bin/add-tool-cheats.sh /usr/local/bin/check-help-coverage.sh \ && /usr/local/bin/create-offline-help-system.sh \ && /usr/local/bin/add-tool-cheats.sh diff --git a/Makefile b/Makefile index 654bdc3..318d0b6 100644 --- a/Makefile +++ b/Makefile @@ -77,4 +77,4 @@ shell-scratch: # Run help coverage check coverage: @echo "Checking help coverage..." - docker run --rm tabledevil/file-analysis:remnux check-help-coverage.sh + docker run --rm tabledevil/file-analysis:latest check-help-coverage.sh